From: Jasper St. Pierre <jstpierre@mecheye.net>
Date: Thu, 20 Dec 2012 03:46:11 +0000 (-0500)
Subject: volume: Don't have a separate syncVisibility method
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~5167
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=66da3f566805cb0891e34e8673eb6056047bfcc3;p=gnome-shell.git

volume: Don't have a separate syncVisibility method

With it doing less now, we can simply do it inline.

https://bugzilla.gnome.org/show_bug.cgi?id=690539
---

diff --git a/js/ui/status/volume.js b/js/ui/status/volume.js
index 9f65d71eb..859b403ca 100644
--- a/js/ui/status/volume.js
+++ b/js/ui/status/volume.js
@@ -228,12 +228,11 @@ const Indicator = new Lang.Class({
         this._volumeMenu = new VolumeMenu(this._control);
         this._volumeMenu.connect('icon-changed', Lang.bind(this, function(menu) {
             let icon = this._volumeMenu.getIcon();
-            this._hasPulseAudio = icon != null;
+            this.actor.visible = (icon != null);
             this.setIcon(icon);
-            this._syncVisibility();
         }));
         this._volumeMenu.connect('headphones-changed', Lang.bind(this, function() {
-            this._syncVisibility();
+            this._headphoneIcon.visible = this._volumeMenu.hasHeadphones;
         }));
 
         this._headphoneIcon = this.addIcon(new Gio.ThemedIcon({ name: 'headphones-symbolic' }));
@@ -247,11 +246,6 @@ const Indicator = new Lang.Class({
         this.actor.connect('scroll-event', Lang.bind(this, this._onScrollEvent));
     },
 
-    _syncVisibility: function() {
-        this.actor.visible = this._hasPulseAudio;
-        this._headphoneIcon.visible = this._volumeMenu.hasHeadphones;
-    },
-
     _onScrollEvent: function(actor, event) {
         this._volumeMenu.scroll(event);
     }